zzkt/osc
1
0
Fork 0
Code Issues 7 Pull requests Projects Releases Activity Actions

Avoid C-isms #5

Merged
PuercoPop merged 4 commits from avoid-c-isms into master 2019-04-02 07:25:07 +00:00
Conversation 1 Commits 4 Files changed 1 +43 -70
PuercoPop commented 2019-03-28 04:12:37 +00:00 (Migrated from github.com)
Copy link

Using ldb/dpb instead of shifting bits and adding 'numbers' is not only more direct but also generates more efficient code in SBCL. This is not the case in all implementations. For example ECL will still compile to code that does more or less the name (ash + ecl_boole). I also refactored common code so that we only need to specify the number of octets to decode or decode and the decoder is derived for us as well as leaving some constants 'unfolded' so that their meaning is more apparent but moving the computation to read-time so the resulting code stays the same.

Using `ldb/dpb` instead of shifting bits and adding 'numbers' is not only more direct but also generates more efficient code in SBCL. This is not the case in all implementations. For example ECL will still compile to code that does more or less the name (ash + ecl_boole). I also refactored common code so that we only need to specify the number of octets to decode or decode and the decoder is derived for us as well as leaving some constants 'unfolded' so that their meaning is more apparent but moving the computation to read-time so the resulting code stays the same.
zzkt commented 2019-04-02 07:25:45 +00:00 (Migrated from github.com)
Copy link

Thanks @PuercoPop

Thanks @PuercoPop
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: zzkt/osc#5
No description provided.
Delete branch "avoid-c-isms"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?