zzkt/osc
1
0
Fork 0
Code Issues7 Pull requests Projects Releases Activity Actions

Revert "key client sockets on the server-side socket name, not the

Browse source 
peername"

This reverts commit 3303d3b7de.

This was a bad idea as it prevents the server handling multiple
clients from the same host. The better solution is to store the
client's address and port in the client object rather than rely on the
status of the client's socket.
This commit is contained in:
Jamie Forth 2015-08-20 11:30:03 +01:00
parent 03b078c20f
commit 85d39627a0
1 changed files with 5 additions and 10 deletions

15
devices/server.lisp
View file

@ -117,18 +117,13 @@
;;;===================================================================== ;;;=====================================================================
(defun register-tcp-client (server transmitter) (defun register-tcp-client (server transmitter)
"Clients are keyed on the names-string of the server-side socket, (setf (gethash (make-peername-string transmitter)
not the peer name because the peer may close the socket after which (clients server))
the peer name is no longer available. FIXME: Maybe we want to store transmitter))
the peername independently of the socket's connection status?"
(let ((client-name (make-name-string transmitter)))
(when (debug-mode server)
(format t "Client registered: ~A~%" client-name))
(setf (gethash client-name (clients server)) transmitter)))
(defun unregister-tcp-client (server transmitter) (defun unregister-tcp-client (server transmitter)
(remhash (make-name-string transmitter) (remhash (make-peername-string transmitter)
(clients server))) (clients server)))
(defun make-unregister-self-fun (server) (defun make-unregister-self-fun (server)
#'(lambda (client) #'(lambda (client)